[installer] remove socket env assertion (backport of #27223) #27334
Conversation
paullegranddc
added
team/fleet-automation
changelog/no-changelog
qa/done
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=38383708 --os-family=ubuntu |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7.55.x #27334 +/- ##
==========================================
- Coverage 44.93% 44.93% -0.01%
==========================================
Files 2354 2354
Lines 272912 272912
==========================================
- Hits 122641 122627 -14
- Misses 140590 140605 +15
+ Partials 9681 9680 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Regression DetectorRegression Detector ResultsRun ID: fd6efc36-76ae-4eec-a441-857f3453ce75 Baseline: 51a7526 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | links |
|---|---|---|---|---|---|
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.21 | [-2.71, +3.13] | |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | +0.20 | [-4.71, +5.10] | |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.05 | [-0.00, +0.10] | |
| ➖ | otel_to_otel_logs | ingress throughput | +0.02 | [-0.36, +0.39] | |
| ➖ | trace_agent_json | ingress throughput | +0.01 | [-0.01, +0.02] | |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.20, +0.20] | |
| ➖ | trace_agent_msgpack | ingress throughput | -0.00 | [-0.01, +0.00] | |
| ➖ | basic_py_check | % cpu utilization | -0.16 | [-2.87, +2.55] | |
| ➖ | file_tree | memory utilization | -0.28 | [-0.38, -0.17] | |
| ➖ | idle | memory utilization | -0.76 | [-0.80, -0.71] | |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -1.97 | [-23.02, +19.09] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
What does this PR do?
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes